Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AGEMOEA for Convex Fronts #407

Merged
merged 5 commits into from
Aug 28, 2024
Merged

AGEMOEA for Convex Fronts #407

merged 5 commits into from
Aug 28, 2024

Conversation

IWNMWE
Copy link
Contributor

@IWNMWE IWNMWE commented Aug 8, 2024

This PR is to fix the drift seen in AGEMOEA for highly convex functions(eg MAF3)

Copy link
Member

@zoq zoq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@IWNMWE
Copy link
Contributor Author

IWNMWE commented Aug 12, 2024

Looks good to me.

Still need to fix a few things. Will make those changes in this week

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second approval provided automatically after 24 hours. 👍

@IWNMWE
Copy link
Contributor Author

IWNMWE commented Aug 14, 2024

That's all the fixes I wanted to do. I think its good to go

@zoq
Copy link
Member

zoq commented Aug 15, 2024

@mlpack-jenkins test this please

@IWNMWE
Copy link
Contributor Author

IWNMWE commented Aug 16, 2024

[ensmallen_tests.global.DemonSGDLogisticRegressionTest] Looks like this test might be failing due to rng seed

@zoq
Copy link
Member

zoq commented Aug 20, 2024

@mlpack-jenkins test this please

@zoq
Copy link
Member

zoq commented Aug 20, 2024

Same here, let's see if that comes back green and merge it.

@IWNMWE
Copy link
Contributor Author

IWNMWE commented Aug 21, 2024

Again the same test is failing. Can we try it again then I can pull these changes in my maf PR and that one should start passing

@zoq
Copy link
Member

zoq commented Aug 22, 2024

@mlpack-jenkins test this please

@zoq zoq merged commit bd6a308 into mlpack:master Aug 28, 2024
4 checks passed
@zoq
Copy link
Member

zoq commented Aug 28, 2024

Thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants